🌐 AI搜索 & 代理 主页
Skip to content

DRA API: add fuzz testing for conversion roundtripping #135707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jkhall81 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DRA API: add fuzz testing for conversion roundtripping #135707

Jkhall81 wants to merge 4 commits into from
+93 −0

Conversation

@Jkhall81
Copy link

@Jkhall81 Jkhall81 commented Dec 10, 2025 •
edited
Loading

DRA API: add fuzz testing for conversion roundtripping

This PR adds automated fuzz testing for DRA API conversion roundtripping similar to staging/src/k8s.io/api/roundtrip_test.go.

Changes:

  1. Added roundtrip_test.go in k8s.io/dynamic-resource-allocation/api/ with fuzz testing
  2. Tests all DRA types (ResourceClaim, ResourceClaimTemplate, ResourceClass, ResourceSlice) across all versions (v1beta1, v1beta2, v1)
  3. Uses the standard Kubernetes fuzzing framework to test automatically generated conversion code

Which issue(s) this PR is related to:
Fixes #134356

Special notes for your reviewer:
This test verifies that the automatically generated conversion code in zz_generated.conversion.go works correctly and prevents regressions. It follows the established pattern from other Kubernetes API roundtrip tests.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 10, 2025

Please note that we're already in Test Freeze for the release-1.35 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.35.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 10 15:42:34 UTC 2025.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 10, 2025

Hi @Jkhall81. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 10, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 10, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jkhall81
Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jkhall81
DRA API: add fuzz testing for conversion roundtripping
7483e2f 
Add automated fuzz testing similar to staging/src/k8s.io/api/roundtrip_test.go.
Tests all DRA types across v1beta1, v1beta2, and v1 versions.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2025
@pohly
Copy link
Contributor

pohly commented Dec 11, 2025

/ok-to-test
/sig node

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2025
@Jkhall81
Copy link
Author

Jkhall81 commented Dec 11, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025
pohly
pohly reviewed Dec 11, 2025
View reviewed changes
staging/src/k8s.io/dynamic-resource-allocation/api/roundtrip_test.go.backup Outdated
Copy link
Contributor

@pohly pohly Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Otherwise it looks good, thanks for taking the time to figure this out.

Copy link
Author

@Jkhall81 Jkhall81 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! The backup file has been removed.
Sure thing. This was interesting.
Let me know if there's anything else you'd like updated.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2025
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

@Jkhall81: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dra-integration e47f0d3 link false /test pull-kubernetes-dra-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klueska klueska Awaiting requested review from klueska

1 more reviewer

@pohly pohly pohly left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Dynamic Resource Allocation
Status: 👀 In review
SIG Node: code and documentation PRs
Status: Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DRA API helper: add automated fuzz testing of conversion roundtripping

3 participants

@Jkhall81 @k8s-ci-robot @pohly