🌐 AI搜索 & 代理 主页
Skip to content

Put pods preempted in WaitOnPermit to backoff queue #135719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Argh4k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Put pods preempted in WaitOnPermit to backoff queue #135719

Argh4k wants to merge 1 commit into from
+185 −2

Conversation

@Argh4k
Copy link
Contributor

@Argh4k Argh4k commented Dec 11, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR changes the behavior of the scheduler when it preempts the pods that are in "WaitOnPermit" phase. Currently the pods are Rejected by a preemption plugin which moves the victim pod to unschedulable queue, adding the information about preemption to PodCondition. It means that this pod will be stuck in unschedulable queue until some event in the cluster pushes it back to backoff/active queue. It seems undesirable as it does not give a strong signal to the component owning the pod to recreate it (compared to default preemption which deletes the pod completely). After this PR the victim pod will be moved to the backoff queue, allowing the scheduler to try to schedule it once again after some time.

Which issue(s) this PR is related to:

This was found as a part of the #132332

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changed the behavior of default scheduler preemption plugin when preempting pods that are in "WaitOnPermit" phase. They are now moved to the scheduler backoff queue instead of being marked as unschedulable.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

/sig scheduling

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

Please note that we're already in Test Freeze for the release-1.35 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.35.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 11 09:40:29 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Argh4k
Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2025
@Argh4k
Copy link
Contributor Author

Argh4k commented Dec 11, 2025

/assign macsko ania-borowiec

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2025

@Argh4k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd dda6159 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gce dda6159 link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@dom4ha dom4ha Awaiting requested review from dom4ha

Assignees

@macsko macsko

@ania-borowiec ania-borowiec

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Scheduling
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Argh4k @k8s-ci-robot @macsko @ania-borowiec