BUG: mplot3d: Don't crash if azim or elev are non-integral #12573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting these via a format string causes 'inf' or 'nan' to be displayed in the status bar, which is much better than crashing because the user tried to rotate.
Contributor
Author
|
This also changes the rendering of |
Merged
timhoffm
approved these changes
Oct 20, 2018
WeatherGod
approved these changes
Oct 20, 2018
Member
|
@meeseeksdev backport to v3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 20, 2018
…ev are non-integral
Member
|
@meeseeksdev backport to v2.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting these via a format string causes 'inf' or 'nan' to be displayed in the status bar, which is much better than crashing because the user tried to rotate.
Extracted from #8896 (comment), since that PR is a can of worms, but this small fix is not.
No unit tests, because testing mouse interaction sounds super hard.