🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 1, 2019

The main point is to remove one not particularly useful customization
point from setup.cfg, and the associated logic in setupext.py.

Minor additional changes in _tkagg.cpp: use METH_VARARGS instead of the
opaque "1" (one can check in Python.h that the values indeed match),
and just use #ifdef _WIN32 to check for Windows-ness
(src/file_compat.h also uses that check so it works).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.1 milestone Jan 3, 2019
The main point is to remove one not particularly useful customization
point from setup.cfg, and the associated logic in setupext.py.

Minor additional changes in _tkagg.cpp: use METH_VARARGS instead of the
opaque "1" (one can check in Python.h that the values indeed match),
and just use `#ifdef _WIN32` to check for Windows-ness
(`src/file_compat.h` also uses that check so it works).
@QuLogic QuLogic merged commit 94fbf2d into matplotlib:master Jan 11, 2019
@anntzer anntzer deleted the windowing-tkagg branch January 11, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants