MAINT install of pinned vers for travis #13282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned version of dependencies need to be installed *after* the rest of the packages. This will downgrade them. Else, sometimes, pip tries to installs the wrong version of the package, and fails.
dstansby
approved these changes
Jan 25, 2019
Contributor
|
I think(?) this is not looking at the problem under the right angle; see #13281 (comment). |
dstansby
requested changes
Jan 29, 2019
Member
dstansby
left a comment
There was a problem hiding this comment.
Actually, I don't think this is the correct thing to do; currently PINNEDVERS is handed over as a constraints file, which just forces versions during the pip command. (See https://github.com/matplotlib/matplotlib/pull/13282/files#diff-354f30a63fb0907d4ad57269548329e3R87)
Member
Author
|
@dstansby I'll check it out. |
Member
Author
|
@dstansby you are correct. I'm going to refactor this to make it more readible. That means the error on v3.0.2-doc is due to a missing constraints. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned version of dependencies need to be installed after the rest of
the packages. This will downgrade them. Else, sometimes, pip tries to installs
the wrong version of the package, and fails.
(forward port of #13281 )