In the build, declare all (compulsory) extension modules together. #14442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1552c3c to
b9bc3e6
Compare
... in a single function. Splitting them over multiple classes doesn't really buy much. Also convert the LibAgg and Qhull classes to toplevel functions, as they play a role similar to add_numpy_flags.
timhoffm
reviewed
Nov 9, 2019
| if platform.python_implementation().lower() == 'pypy': | ||
| ext.extra_compile_args.append('-DPYPY=1') | ||
| return ext | ||
| yield ext |
Member
There was a problem hiding this comment.
Maybe it's clearer to just return a 1-element list here?
Suggested change
| yield ext | |
| return [ext] |
Contributor
Author
There was a problem hiding this comment.
I think that's actually less consistent with the sole other (non-empty) implementation of get_extensions() (the main list), but can do the change if you insist.
Member
There was a problem hiding this comment.
While return specifies the return value completely, yield specifies only one element (of possibly many), so you need more context to infer the full returned result. But I don't really mind.
timhoffm
approved these changes
Nov 9, 2019
QuLogic
approved these changes
Mar 21, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in a single function.
Splitting them over multiple classes doesn't really buy much.
Also convert the LibAgg and Qhull classes to toplevel functions,
as they play a role similar to add_numpy_flags.
I plan to do the same to agg and tkagg once #13075 gets in.done.PR Summary
PR Checklist