Try to install the Noto Sans CJK font #20851
Conversation
66965e0 to
fd2d801
Compare
|
Zen Hei seems packaged for Ubuntu, but in Universe, Not sure if we need to do something special to allow installing it. |
fd2d801 to
cb0af05
Compare
|
The SourceForge download of Zen Hei sometimes fails, so this was probably not a good idea. Google's Noto fonts seem to be better packaged in various systems, so perhaps something like Noto Sans CJK SC could be more useful. For context: some of the new font changes by @aitikgupta crash on my computer (an M1 Mac) but not on his (I believe Linux on x86), so I would like to add a more cross-platform test with a CJK font and see if we can replicate the crash in CI. |
c04d923 to
a71185c
Compare
On Linux and Mac. Add a font_manager test that loads the font and uses it. This could be useful in testing the multi-font support (matplotlib#20740 etc). I couldn't get the font installed on Windows. There is a Chocolatey installer that installs all of the Noto fonts, which takes a really long time to run.
10558de to
bf38aa9
Compare
|
I'm giving up on Windows - the Chocolatey package installs all of the Noto fonts and takes half an hour to do it, and my PowerShell skills are not enough to install just one. |
aitikgupta
left a comment
There was a problem hiding this comment.
I think this can be a good validation for testing the font fallback.
If we do keep this, do we also need to keep installing ZenHei for CI (on Linux) as well?
Noto CJK could potentially replace it right? (I'll do a local installation to test out the actual difference between number of glyphs)
On Linux and Mac. Add a font_manager test that loads the font and uses it. This could be useful in testing the multi-font support (#20740 etc).
I couldn't get the font installed on Windows. There is a Chocolatey installer that installs all of the Noto fonts, which takes a really long time to run.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).