Fix wrong binding of JS this #2310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inside the closure this binds to the WebSocket object rather than to the figure object.
Member
|
Looks fine. @mdboom, would you mind taking a look and merging? |
Member
|
Thanks. This looks good. I'll test and merge when I get back from vacation next week. |
Member
|
Thanks for finding this. I was stumped as to why the onload handler wasn't working. I'm reviving #2054, which is a pretty major refactor of the javascript, so I think it best to just address this and test this there, which I hope to have in a mergeable state soon. |
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
Aug 26, 2013
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
Aug 26, 2013
Member
|
Integrated manually as part of 2b241cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inside the closure this binds to the WebSocket object rather than to the figure object. I only briefly tested this but its meaning should be apparent.