Remove soon to be deprecated nan/inf aliases #26458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Aug 4, 2023
tacaswell
approved these changes
Aug 4, 2023
Member
|
The one failure is tk + subprocess, not worth re-running. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 5, 2023
ksunden
added a commit
that referenced
this pull request
Aug 5, 2023
…458-on-v3.7.x Backport PR #26458 on branch v3.7.x (Remove soon to be deprecated nan/inf aliases)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
reference #26422
These aliases are among the more confident to be removed from numpy, and their replacement is already more commonly used in the codebase, so this is improving consistency and future proofing.
PR checklist