Omit MOVETO lines from nearest contour logic #27334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a48e425 to
52bf8e9
Compare
Member
Author
|
Test is now written, I decided not to make it an image test, as all I really need to check is that the correct contour is chosen, and that can be done with a simple assertion. However here are the images produced by that code if reviewers are interested: Before the change:
With this patch:
The main point being that the |
QuLogic
approved these changes
Nov 16, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 16, 2023
ksunden
added a commit
that referenced
this pull request
Nov 17, 2023
…334-on-v3.8.x Backport PR #27334 on branch v3.8.x (Omit MOVETO lines from nearest contour logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27333
PR summary
I would like to simplify down the reproducer further and add a test, but I think the code change itself is largely good.
Just uses
path._iter_connected_components()to break apart the connected subpaths so that the MOVETO lines don't get considered as close.There is a small amount of bookkeeping to make sure that the reported index includes all of the subpaths already processed.
PR checklist