TST: Fix test_pickle_load_from_subprocess in a dirty tree #28781
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
would it be better to use |
Member
Author
|
I wasn't sure when that was added, but it looks like 5.0.1, so that should be fine. |
86bc147 to
94fb5f1
Compare
timhoffm
reviewed
Sep 5, 2024
For a ditry tree, `setuptools-scm` adds the date to the end of the version. This test runs a subprocess and `subprocess_run_helper` will set `SOURCE_DATE_EPOCH=0`, which forces the date to be 1970-01-01, triggering a mismatched version warning on unpickle. Since we aren't testing the version-compatibility warning, set `SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MATPLOTLIB` in the subprocess call so that versions match. Also, set the `dist_name` parameter when querying setuptools-scm or it won't check that environment variable.
94fb5f1 to
16fad2e
Compare
timhoffm
approved these changes
Sep 5, 2024
tacaswell
approved these changes
Sep 6, 2024
Member
|
I'm going to merge over a test_determinism_svg test on one platform. |
Member
|
Thank you @QuLogic ! This has been bugging me for a while but I have not had time to track it down. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
For a ditry tree,
setuptools-scmadds the date to the end of the version. This test runs a subprocess andsubprocess_run_helperwill setSOURCE_DATE_EPOCH=0, which forces the date to be 1970-01-01, triggering a mismatched version warning on unpickle.Since we aren't testing the version-compatibility warning, set
SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MATPLOTLIBin the subprocess call so that versions match.We also need to set the
dist_nameparameter when querying setuptools-scm or it won't check that environment variable.This is something I've long seen, but never investigated.
PR checklist