🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@scottshambaugh
Copy link
Contributor

@scottshambaugh scottshambaugh commented Oct 16, 2024

PR summary

I don't like the example I made that shows clipping to 3D axis limits in #27349. It's not clear which of the random points are actually supposed to be outside the axis limits. Switched the gallery example and what's new plot to a continuous function, which I think is easier to interpret.

Before:
image

After:
sphx_glr_axlim_clip_001_2_00x

PR checklist

@scottshambaugh scottshambaugh added this to the v3.10.0 milestone Oct 16, 2024
@scottshambaugh scottshambaugh added topic: mplot3d PR: bugfix Pull requests that fix identified bugs labels Oct 16, 2024
@scottshambaugh
Copy link
Contributor Author

Update: this also uncovered a bug in axlim_clip for Line3DCollection, which is now fixed.

@scottshambaugh scottshambaugh changed the title DOC: Better example for 3D axlim_clip argument DOC / BUG: Better example for 3D axlim_clip argument Oct 16, 2024
@scottshambaugh scottshambaugh force-pushed the axlim_clip_example branch 2 times, most recently from 8d1bd4e to 87bad30 Compare October 16, 2024 16:46
@scottshambaugh scottshambaugh marked this pull request as ready for review October 16, 2024 16:46
scottshambaugh and others added 2 commits October 16, 2024 21:27
Tests

Tests

Tests

Update lib/mpl_toolkits/mplot3d/art3d.py

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@scottshambaugh
Copy link
Contributor Author

Updated to add tags to the example

@QuLogic QuLogic merged commit 940b897 into matplotlib:main Oct 17, 2024
@scottshambaugh scottshambaugh deleted the axlim_clip_example branch October 17, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: examples files in galleries/examples PR: bugfix Pull requests that fix identified bugs topic: mplot3d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants