TST: Use text placeholders for empty legends #29908
Conversation
|
👍🏻 now needs a rebase. |
timhoffm
left a comment
There was a problem hiding this comment.
Now that text uses placeholders, can we change label=" " to some actual text like label="foo" or label="label"? This feels more normal and may be less confusing when reading the test, or when taking the code and running it without placeholders for debug purposes. The label=" " was only there to reduce the font-rendering impact. I don't see a reason we should keep it.
eb51274 to
600ad50
Compare
There was a problem hiding this comment.
Why don't the black boxesh show up here like they do in the png?
There was a problem hiding this comment.
Ah, it just stopped after the first extension, and I didn't catch it.
There was a problem hiding this comment.
Because the mpl20 style doesn't have patch edges, I also decided to remove the forced blue colour on the bars, since they all look like single bars instead of stacked ones.
There was a problem hiding this comment.
I also reverted the texts here to the values before 966e467
92cd616 to
2053e8c
Compare
2053e8c to
6f93bdc
Compare
These tests use `remove_text=True` and set legend labels to empty strings. However, they are still affected by font metrics because even the empty string is as tall as the line height (which is calculated from the height of the "lp" string.)
6f93bdc to
7cdc74f
Compare
PR summary
These tests use
remove_text=Trueand set legend labels to empty strings. However, they are still affected by font metrics because even the empty string is as tall as the line height (which is calculated from the height of the "lp" string.)This depends on #29907.
PR checklist