-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Create RCKeyType #30316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+402
−12
Merged
Create RCKeyType #30316
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cabc266
Create RCKeyType
ZPyrolink 7fb39ed
Create RCGroupKeyType
ZPyrolink e27095e
Rename types for consistent naming
ZPyrolink 4b0773f
Replace str with RcKeyType on RcParams
ZPyrolink 612b541
Replace str with RcKeyType or RcGroupKeyType on matplotlib
ZPyrolink b29f60e
Accord pyplot and matplotlib type hints
ZPyrolink 1865048
Correct RcParams dict key type
ZPyrolink 81f9d6b
Correct mypy errors
ZPyrolink fea96f4
Merge remote-tracking branch 'upstream/main' into typing/rc
ZPyrolink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no getter for a group so I think ignoring the error is the only solution.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume mypy is complaining here. Would it help to make the list explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately mypy consider
textfontas astrand the sum also as str so we have the same errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok in that case, ignoring is likely the simplest solution.