Add os.PathLike support to FT2Font constructor, and FontManager #30573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 17, 2025
Since we pass the filename to `io.open`, we can accept everything it can. Also, fix the return value of `FT2Font.fname`, which could be `bytes` if that was initially provided.
994d3cd to
18ffa02
Compare
tacaswell
reviewed
Sep 25, 2025
| with pytest.raises(FileNotFoundError): | ||
| get_font(bytes(tmp_path / 'non-existent-font-name.ttf')) | ||
|
|
||
| # Not really public, but get_font doesn't expose non-filename constructor. |
Member
There was a problem hiding this comment.
note to future reviewers, this was removed as redundent with other test
tacaswell
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since we pass the filename to
io.open, we can accept everything it can.Also, fix the return value of
FT2Font.fname, which could bebytesif that was initially provided.I extracted this out of #30334 since it's independent
PR checklist