Fix test_mult_norm_call_types on 32-bit systems #30629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 3, 2025
lib/matplotlib/tests/test_colors.py
Outdated
| mn.vmax = (2, 2) | ||
|
|
||
| vals = np.arange(6).reshape((3,2)) | ||
| vals = np.arange(6, dtype='int64').reshape((3, 2)) |
Member
There was a problem hiding this comment.
I assume what fails is the asserion below
assert no_norm_out[1].dtype == np.dtype('int64')
If so, wouldn't it be slightly better to leave vals as is and change the assert to
assert no_norm_out[1].dtype == vals.dtype
?
Member
Author
There was a problem hiding this comment.
Yes, fair, that would work as well.
In that case, the default int is also 32-bit, so the test will fail to be equal to `int64`. So instead of the implicit type, use an explicit one.
52c7504 to
6992b98
Compare
timhoffm
approved these changes
Oct 5, 2025
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 12, 2025
In that case, the default int is also 32-bit, so the test will fail to be equal to `int64`. This is similar to matplotlib#30629.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 12, 2025
In that case, the default int is also 32-bit, so the test will fail to be equal to `int64`. This is similar to matplotlib#30629.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 12, 2025
In that case, the default int is also 32-bit, so the test will fail to be equal to `int64`. This is similar to matplotlib#30629.
1 task
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 13, 2025
In that case, the default int is also 32-bit, so the test will fail to be equal to `int64`. This is similar to matplotlib#30629.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In that case, the default int is also 32-bit, so the test will fail to be equal to
int64. So instead of the implicit type, use an explicit one.PR checklist