-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Handle single color for multiple datasets in hist
#30867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gapplef
wants to merge
7
commits into
matplotlib:main
Choose a base branch
from
gapplef:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f959bb1
Handle single color for multiple datasets in `hist`
gapplef 9b78318
Merge branch 'matplotlib:main' into main
gapplef cb711e9
Update what's new: handle single color for multiple datasets in hist
gapplef 1f2bb9b
Update docstring: handle single color for multiple datasets in hist
gapplef 79906bb
Update docstring to complies with the guidelines
gapplef f93ac2e
New test for ``hist()``: single color with multiple datasets.
gapplef d718961
simplify what's new: handle single color for multiple datasets in hist
gapplef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ``hist()`` supports a single color for multiple datasets | ||
| -------------------------------------------------------- | ||
|
|
||
| It is now possible pass a single *color* value to `~.Axes.hist()`. This value | ||
| is applied to all datasets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2580,6 +2580,13 @@ def test_hist_zorder(histtype, zorder): | |||||||||||||
| assert patch.get_zorder() == zorder | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| def test_hist_single_color_multiple_datasets(): | ||||||||||||||
| # Test a single color for multiple datasets | ||||||||||||||
| # https://github.com/matplotlib/matplotlib/issues/30857 | ||||||||||||||
| data = [[0, 1, 2], [3, 4, 5]] | ||||||||||||||
| plt.hist(data, color='k') | ||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This only tests that the call does not blow up. It does not verify whether the right thing happens. Please refine:
Suggested change
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| def test_stairs_no_baseline_fill_warns(): | ||||||||||||||
| fig, ax = plt.subplots() | ||||||||||||||
| with pytest.warns(UserWarning, match="baseline=None and fill=True"): | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of the first line is already expressed through the function name.
We typically do not reference github issues. For future readers, it does not matter whether the test was added as part of the original implementation or through a later issue. If somebody really want to know this they can reconstruct the PR from the commit and the issue from the PR.