🌐 AI搜索 & 代理 主页
Skip to content

chore(ts-eslint): patch no-deprecated rule tu support exports/re-exports #34748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hotell merged 5 commits into from
Jul 16, 2025
Merged

chore(ts-eslint): patch no-deprecated rule tu support exports/re-exports #34748

Hotell merged 5 commits into from
Jul 16, 2025

Conversation

@mainframev
Copy link
Contributor

@mainframev mainframev commented Jun 29, 2025 •
edited by Hotell
Loading

Patching @typescript-eslint/no-deprecated rule to support exports/reexports. Patch will be remove once it will become part of no-deprecated rule in @typescript-eslint/eslint-plugin

Previous Behavior

/Users/fluentui/packages/react-components/react-components/src/index.ts
  106:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  111:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  118:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  137:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  140:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  244:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  377:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  565:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  581:3   warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')
  633:34  warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-deprecated')

New Behavior

No anymore reported unused directives and after removing some suppressions rule reports with errors.

/Users/victorgenaev/fluentui/packages/react-components/react-components/src/index.ts
  106:3  error  `getNativeElementProps` is deprecated. use getIntrinsicElementProps instead, it is a type-safe version of this method      @typescript-eslint/no-deprecated
  111:3  error  `getSlots` is deprecated. use slot.always or slot.optional combined with assertSlots instead                               @typescript-eslint/no-deprecated
  117:3  error  `resolveShorthand` is deprecated. use slot.always, slot.optional, slot.resolveShorthand combined with assertSlots instead  @typescript-eslint/no-deprecated

Spots deprecated exports in all monorepo packages

@mainframev mainframev self-assigned this Jun 29, 2025
@mainframev mainframev force-pushed the chore/path-ts-eslint branch from a08e116 to d0d475f Compare June 29, 2025 23:48
@github-actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

github-actions bot commented Jun 30, 2025

Pull request demo site: URL

github-actions[bot]
github-actions bot reviewed Jun 30, 2025
View reviewed changes
Hotell
Hotell reviewed Jun 30, 2025
View reviewed changes
@mainframev mainframev force-pushed the chore/path-ts-eslint branch from d0d475f to 69053d7 Compare June 30, 2025 14:16
@mainframev mainframev force-pushed the chore/path-ts-eslint branch 3 times, most recently from f3f0e57 to 25f609d Compare July 8, 2025 11:39
@mainframev mainframev marked this pull request as ready for review July 8, 2025 11:40
@mainframev mainframev requested review from a team, ValentinaKozlova and khmakoto as code owners July 8, 2025 11:40
@mainframev mainframev force-pushed the chore/path-ts-eslint branch 5 times, most recently from a77b446 to 163dfcf Compare July 11, 2025 11:43
@github-actions github-actions bot added the CI label Jul 11, 2025
Hotell
Hotell reviewed Jul 11, 2025
View reviewed changes
@mainframev mainframev force-pushed the chore/path-ts-eslint branch from 029be62 to a15cf0d Compare July 11, 2025 16:08
@github-actions github-actions bot removed the CI label Jul 11, 2025
@mainframev mainframev force-pushed the chore/path-ts-eslint branch from a15cf0d to 25c6aac Compare July 11, 2025 16:08
@mainframev mainframev marked this pull request as draft July 11, 2025 17:34
@mainframev mainframev force-pushed the chore/path-ts-eslint branch 2 times, most recently from 416c276 to 3042f0b Compare July 14, 2025 09:17
@mainframev mainframev marked this pull request as ready for review July 14, 2025 09:58
@mainframev mainframev requested a review from Hotell July 14, 2025 09:58
@mainframev mainframev force-pushed the chore/path-ts-eslint branch from 895047b to 1d2768e Compare July 16, 2025 09:26
@Hotell Hotell merged commit f71a991 into microsoft:master Jul 16, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Hotell Hotell Hotell approved these changes

@ValentinaKozlova ValentinaKozlova Awaiting requested review from ValentinaKozlova ValentinaKozlova is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

Assignees

@mainframev mainframev

Labels

Area: Linting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mainframev @Hotell