fix: Fix a typo in Hermes-utils.rb #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Jul 1, 2025
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Jul 2, 2025
## Summary: Discovered when cherry-picking microsoft#2531 into microsoft#2530. I didn't catch it before because we don't actually run through this part on the main branch. ## Test Plan: No effects on main branch, but microsoft#2530 CIs should succeed now. Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Discovered when cherry-picking #2531 into #2530. I didn't catch it before because we don't actually run through this part on the main branch.
Test Plan:
No effects on main branch, but #2530 CIs should succeed now.