Initialize Plus tag if not set in FONT-VARIANT-POSITION #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request ensures that the $this->OTLtags['Plus'] index is always initialized before being used in the FONT-VARIANT-POSITION case. Previously, if the 'Plus' index was not set, accessing it would result in an "Undefined index: Plus" PHP error. With this change, the code now checks if $this->OTLtags['Plus'] is set. If not, it initializes it as an empty string before any manipulation. This prevents runtime errors and improves code reliability when processing font variant positions. Motivation and Rationale The change is necessary to avoid PHP notices and potential fatal errors when the 'Plus' tag is not initialized. Many code paths can reach this logic without guaranteeing that $this->OTLtags['Plus'] exists, especially when processing new or edge-case font variants. This fix makes the code more robust and easier to maintain. Impact Prevents "Undefined index: Plus" errors. Improves stability when handling font position variants. Does not affect any other functionality or tags. Testing Verified that the error no longer occurs in scenarios where FONT-VARIANT-POSITION is set without prior initialization of $this->OTLtags['Plus']. Existing and new unit tests for font variant processing pass. Changelog Added: Always initialize $this->OTLtags['Plus'] before use in FONT-VARIANT-POSITION to prevent undefined index errors.
Member
|
Thank you for the PR. Please provide a unit test representing the undefined index error without this code change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request ensures that the
$this->OTLtags['Plus']index is always initialized before being used in the FONT-VARIANT-POSITION case.Previously, if the
Plusindex was not set, PHP would throw an "Undefined index: Plus" error.With this change, the code checks whether
$this->OTLtags['Plus']is set.If not, it initializes it as an empty string before any manipulation.
This prevents runtime errors and improves reliability when processing font variant positions.
Motivation and Rationale
Pluskey is not initialized.$this->OTLtags['Plus']exists, especially when handling new or edge-case font variants.Impact
Testing
$this->OTLtags['Plus'].Changelog
$this->OTLtags['Plus']before use in FONT-VARIANT-POSITION to prevent undefined index errors.