🌐 AI搜索 & 代理 主页
Skip to content

MAINT: remove use of ld_classic on macOS #28713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgommers merged 2 commits into from
Apr 15, 2025
Merged

MAINT: remove use of ld_classic on macOS #28713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d2973b
MAINT: remove use of ld_classic on macOS
adamjstewart Apr 15, 2025
2d94136
Add changelog
adamjstewart Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release/upcoming_changes/28713.change.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove use of -Wl,-ld_classic on macOS. This hack is no longer needed by Spack, and results in libraries that cannot link to other libraries built with ld (new).
6 changes: 0 additions & 6 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,5 @@ if cc_id.startswith('clang')
endif
endif

if host_machine.system() == 'darwin' and cc.has_link_argument('-Wl,-ld_classic')
# New linker introduced in macOS 14 not working yet with at least OpenBLAS in Spack,
# see gh-24964 (and linked scipy issue from there).
add_project_link_arguments('-Wl,-ld_classic', language : ['c', 'cpp'])
endif

subdir('meson_cpu')
subdir('numpy')
Loading