🌐 AI搜索 & 代理 主页
Skip to content

BUG: avoid segmentation fault in string_expandtabs_length_promoter #29920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 2 commits into from
Oct 10, 2025
Merged

BUG: avoid segmentation fault in string_expandtabs_length_promoter #29920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7819364
BUG: Avoid segfault when calling `numpy._core.strings._expandtabs_len…
riku-sakamoto Oct 10, 2025
f123253
TST: add tests to check `numpy._core.strings._expandtabs_length`
riku-sakamoto Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion numpy/_core/src/umath/string_ufuncs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ string_expandtabs_length_promoter(PyObject *NPY_UNUSED(ufunc),
PyArray_DTypeMeta *const op_dtypes[], PyArray_DTypeMeta *const signature[],
PyArray_DTypeMeta *new_op_dtypes[])
{
Py_INCREF(op_dtypes[0]);
Py_XINCREF(op_dtypes[0]);
new_op_dtypes[0] = op_dtypes[0];
new_op_dtypes[1] = NPY_DT_NewRef(&PyArray_Int64DType);
new_op_dtypes[2] = PyArray_DTypeFromTypeNum(NPY_DEFAULT_INT);
Expand Down
15 changes: 15 additions & 0 deletions numpy/_core/tests/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import pytest

import numpy as np
from numpy._core._exceptions import _UFuncNoLoopError
from numpy.testing import IS_PYPY, assert_array_equal, assert_raises
from numpy.testing._private.utils import requires_memory

Expand Down Expand Up @@ -821,6 +822,20 @@ def test_expandtabs_raises_overflow(self, dt):
np.strings.expandtabs(np.array("\ta\n\tb", dtype=dt), sys.maxsize)
np.strings.expandtabs(np.array("\ta\n\tb", dtype=dt), 2**61)

def test_expandtabs_length_not_cause_segfault(self, dt):
# see gh-28829
with pytest.raises(
_UFuncNoLoopError,
match="did not contain a loop with signature matching types",
):
np._core.strings._expandtabs_length.reduce(np.zeros(200))

with pytest.raises(
_UFuncNoLoopError,
match="did not contain a loop with signature matching types",
):
np.strings.expandtabs(np.zeros(200))

FILL_ERROR = "The fill character must be exactly one character long"

def test_center_raises_multiple_character_fill(self, dt):
Expand Down
Loading