Update meson.options #30317
Update meson.options #30317
Conversation
1.grouped sections logically(BLAS/LAPACK, MKL,threading,CPU Dispatch,SIMD ) 2.added choices for options that have implied valid values 3.descriptions cleaned and standardized 4. default values remain untouched.
rgommers
left a comment
There was a problem hiding this comment.
Thanks @Mohataseem89. This is mostly a cosmetic PR, which we normally prefer not to receive. But the choices addition is helpful, so I'm willing to review and merge this PR.
I added some comments that need to be addressed. In addition, the line spacing is inconsistent - please make it consistent by either using always 0 or always 1 empty line between options that are grouped together with a comment.
| # Threading & Parallelism | ||
| option('disable-threading', type: 'boolean', value: false, | ||
| description: 'Disable threading support (see `NPY_ALLOW_THREADS` docs)') | ||
| description: 'Completely disable NumPy threading support') |
There was a problem hiding this comment.
The NPY_ALLOW_THREADS hint is useful, it guides the user to https://numpy.org/devdocs/reference/c-api/array.html#threading-support. Please restore its mention.
| description: 'Order of LAPACK libraries to search for. E.g.: mkl,openblas,lapack') | ||
| description: 'Preferred search order for LAPACK libraries (e.g., mkl, openblas, lapack)') | ||
|
|
||
| option('allow-noblas', type: 'boolean', value: true, |
There was a problem hiding this comment.
This goes together with the blas/lapack options, it's better in its original place - please put it back there.
| description: 'Symbol suffix for BLAS/LAPACK symbols (if any)') | ||
|
|
||
|
|
||
| # MKL / Library Behavior |
There was a problem hiding this comment.
This is only a single option so doesn't seem to deserve a separate header; it's part of the BLAS options.
| choices: ['auto', 'seq', 'iomp', 'gomp', 'tbb'], | ||
| description: 'Threading backend for MKL') | ||
|
|
||
| option('disable-svml', type: 'boolean', value: false, |
There was a problem hiding this comment.
These three options should be part of the SIMD options sections
1.grouped sections logically(BLAS/LAPACK,
MKL,threading,CPU Dispatch,SIMD )
2.added choices for options that have implied valid values
3.descriptions cleaned and standardized
4. default values remain untouched.