ENH: Add sort_compare dtype slot to register new-style sorts
#30415
+192
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comparison function
ngoldbaum
reviewed
Dec 12, 2025
doc/source/reference/c-api/array.rst
Outdated
| If defined, implements a comparison function for two array elements | ||
| for use in sorting and argsorting. This can be defined in place of the | ||
| custom sort functions using the ArrayMethod API (see :ref:`array-methods-sorting`) | ||
| to implement sorting for the DType. |
Member
There was a problem hiding this comment.
maybe add a mention for why you'd want to do this - e.g. if comparisons have some big cost that can be amortized over the whole array
Contributor
Author
There was a problem hiding this comment.
I've added a note - a bit on the detailed side, hopefully that works, thanks!
Contributor
Author
|
Thanks for looking @ngoldbaum!
Agreed, the full loop implementation would probably be overkill in many cases. I think this would be necessary to expose the sorts on the user-dtypes too since they don't define full sorts now, so a good way to test the new infrastructure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #29737 and #30328 (and supersedes #29987) to implement a
sort_compareslot that can be used to register sorting methods using a comparison function. This functionality also existed in the ArrFuncs slots, but now we implement the new-style sorting methods, and the array method context is passed to the comparison function rather than the array itself.I've tested this with
mpfdtypeon the user dtypes repo (though having a bit of an issue with installation... the slot wasn't visible there, so had to redefine just the macro). Unfortunately there don't seem to be dtypes we can write tests for within numpy itself, though I did a small experiment with the scaled float dtype. ping @seberg @mhvk @ngoldbaum if you're interested - thanks!