BUG: Return rank 0 for empty matrices in matrix_rank #30422
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix trailing whitespace causing lint failure and simplify the empty-matrix rank assertion.
seberg
reviewed
Dec 12, 2025
|
|
||
| # Handle empty matrices - rank is 0 for matrices with 0 rows or 0 columns | ||
| if A.size == 0: | ||
| return 0 |
Member
There was a problem hiding this comment.
I wonder if we should just add initial=0 which I assume also works. The tests you added are missing the case of np.zeros((0, 5, 5)) where this return is clearly incorrect.
EDIT: Actually, while we are here, can you check if we don't return np.intp(0) on the last return? We may want to adjust the return type for the other early return as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
np.linalg.matrix_rankwhere empty matrices(previously with 0 rows or 0 columns) would raise a ValueError due to
attempting a reduction operation on a zero-size array.
Changes include:
matrix_rank.Files modified:
numpy/linalg/_linalg.pynumpy/linalg/tests/test_linalg.pyCloses #30421