🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jan 2, 2026

Please review this simple change to a recently added gtest to avoid triggering
-Wzero-as-null-pointer-constant warnings when that warning is enabled.

There are two parts to the change. One is just an obvious replacement of 0
with nullptr.

The other is the removal of a gtest assertion. That assertion's predicate is
attempting to verify the CompressedKlassPointers state has been initialized.
But the test being used (null pointer <= base pointer) is technically invalid;
ordered comparisons between a pointer and null are UB. And even ignoring that,
the compiler may decide the comparison is tautologially true, or it may always
be true at runtime, because pointer comparison is treated as unsigned by at
least some compilers. It would be better done via an is_initialized() function
in CompressedKlassPointers, or use == with the initial "uninitialized" value
of -1. But we're already asserting initialization in the implementation of the
base() function, so at least in debug builds we've already verified
initialization. It doesn't seem worthwhile adding is_initialized() or breaking
through the abstraction and using -1.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374446: Fix -Wzero-as-null-pointer-constant warnings in test_compressedKlass.cpp (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29016/head:pull/29016
$ git checkout pull/29016

Update a local copy of the PR:
$ git checkout pull/29016
$ git pull https://git.openjdk.org/jdk.git pull/29016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29016

View PR using the GUI difftool:
$ git pr show -t 29016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29016.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2026

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant