🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@jeremy-smith-maco
Copy link
Contributor

Hoping to fix any issues so that a release can be done. :)

@jeremy-smith-maco
Copy link
Contributor Author

jeremy-smith-maco commented Mar 21, 2025

Not sure what these errors are caused by

Error: Missing download info for actions/upload-artifact@v3

Edit: Looks like it needs to upgrade to v4 as of January 30th

Edit: Fix that error but some tests seem to be failing still

@jeremy-smith-maco jeremy-smith-maco force-pushed the fix-clang-format branch 3 times, most recently from 08613e7 to 7a719c6 Compare March 21, 2025 05:30
@jeremy-smith-maco jeremy-smith-maco force-pushed the fix-clang-format branch 4 times, most recently from 5017770 to 3b1e5d9 Compare April 1, 2025 01:33
@jeremy-smith-maco
Copy link
Contributor Author

I've made some progress on the failing tests.

Now seems to be an issue with cmake when building librabbitmq, but it isn't consistent. Sometimes fails, sometimes not.

@jeremy-smith-maco jeremy-smith-maco force-pushed the fix-clang-format branch 5 times, most recently from 7307b3d to d8ef097 Compare April 1, 2025 03:51
@jeremy-smith-maco
Copy link
Contributor Author

jeremy-smith-maco commented Apr 1, 2025

Looks like the runner, both ubuntu 20.04 and 22.04, sometimes uses a slightly newer version that has cmake 4 in it which breaks and sometimes uses a slightly older version which is fine so it randomly works.

Looks like they are completely removing the 20.04 runner very soon as well so something will have to be done here to fix it.

actions/runner-images#11101

@jeremy-smith-maco
Copy link
Contributor Author

jeremy-smith-maco commented Apr 2, 2025

These changes should make the tests consistently pass. I have done the following, but this can be changed if there is a more preferred approach of course:

  • Manually install clang 11 and cmake 3.22.6 (both are cached so should realistically only have to do it once) - this avoids having to use cmake 4 randomly which breaks the build
  • If testing rabbitmq 0.10.0 or below, will manually install openSSL 1.1.1 and force cmake to use this when building librabbitmq (also cached, so should only be installed once)
  • Always uses ubuntu 22.04 since 20.04 will be gone soon. Didn't test with 24.04 but may also just work with that

If it all looks good, tests pass and you're happy with the changes, please merge and release if possible. :)

@jeremy-smith-maco
Copy link
Contributor Author

@lstrojny Just tagging you in-case you haven't seen this please :)

@jeremy-smith-maco
Copy link
Contributor Author

@bkw Any chance you are able to take a look at this and maybe release a new version if all is good please?

@dzuelke
Copy link

dzuelke commented Nov 27, 2025

@lstrojny ping - could you merge this PR? This would unblock a bunch of other stuff that currently has CI failing, e.g. #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants