-
-
Notifications
You must be signed in to change notification settings - Fork 123
Fix clang format errors #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Fix clang format errors #593
Conversation
|
Not sure what these errors are caused by
Edit: Looks like it needs to upgrade to v4 as of January 30th Edit: Fix that error but some tests seem to be failing still |
08613e7 to
7a719c6
Compare
5017770 to
3b1e5d9
Compare
|
I've made some progress on the failing tests.
Now seems to be an issue with cmake when building librabbitmq, but it isn't consistent. Sometimes fails, sometimes not. |
7307b3d to
d8ef097
Compare
|
Looks like the runner, both ubuntu 20.04 and 22.04, sometimes uses a slightly newer version that has cmake 4 in it which breaks and sometimes uses a slightly older version which is fine so it randomly works. Looks like they are completely removing the 20.04 runner very soon as well so something will have to be done here to fix it. |
d8ef097 to
ed6e575
Compare
ed6e575 to
2d0c908
Compare
|
These changes should make the tests consistently pass. I have done the following, but this can be changed if there is a more preferred approach of course:
If it all looks good, tests pass and you're happy with the changes, please merge and release if possible. :) |
|
@lstrojny Just tagging you in-case you haven't seen this please :) |
|
@bkw Any chance you are able to take a look at this and maybe release a new version if all is good please? |
Hoping to fix any issues so that a release can be done. :)