Suppress -Warray-parameter warnings in pgcrypto/sha2.c.

tglsfdc · tglsfdc · commit d754ccc1ec9f · 2021-12-12T20:24:53.000-05:00
This is exactly the same problem as commit 1b242f4 fixed in ecpg, but in contrib/pgcrypto. Commit 273c458 eliminated the problem here for v10 and up. We hadn't noticed for exactly the same reasons enumerated in bbbf22c. Back-patch down to 9.2, pursuant to newly-established project policy about keeping out-of-support branches buildable. Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
diff --git a/contrib/pgcrypto/sha2.c b/contrib/pgcrypto/sha2.c
@@ -549,7 +549,7 @@ SHA256_Last(SHA256_CTX *context)
 }
 
 void
-SHA256_Final(uint8 digest[], SHA256_CTX *context)
+SHA256_Final(uint8 digest[SHA256_DIGEST_LENGTH], SHA256_CTX *context)
 {
 	/* If no digest buffer is passed, we don't bother doing this: */
 	if (digest != NULL)
@@ -877,7 +877,7 @@ SHA512_Last(SHA512_CTX *context)
 }
 
 void
-SHA512_Final(uint8 digest[], SHA512_CTX *context)
+SHA512_Final(uint8 digest[SHA512_DIGEST_LENGTH], SHA512_CTX *context)
 {
 	/* If no digest buffer is passed, we don't bother doing this: */
 	if (digest != NULL)
@@ -922,7 +922,7 @@ SHA384_Update(SHA384_CTX *context, const uint8 *data, size_t len)
 }
 
 void
-SHA384_Final(uint8 digest[], SHA384_CTX *context)
+SHA384_Final(uint8 digest[SHA384_DIGEST_LENGTH], SHA384_CTX *context)
 {
 	/* If no digest buffer is passed, we don't bother doing this: */
 	if (digest != NULL)
@@ -966,7 +966,7 @@ SHA224_Update(SHA224_CTX *context, const uint8 *data, size_t len)
 }
 
 void
-SHA224_Final(uint8 digest[], SHA224_CTX *context)
+SHA224_Final(uint8 digest[SHA224_DIGEST_LENGTH], SHA224_CTX *context)
 {
 	/* If no digest buffer is passed, we don't bother doing this: */
 	if (digest != NULL)

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ SHA256_Last(SHA256_CTX *context)`
`549`	`549`	`}`
`550`	`550`
`551`	`551`	`void`
`552`		`-SHA256_Final(uint8 digest[], SHA256_CTX *context)`
	`552`	`+SHA256_Final(uint8 digest[SHA256_DIGEST_LENGTH], SHA256_CTX *context)`
`553`	`553`	`{`
`554`	`554`	`/* If no digest buffer is passed, we don't bother doing this: */`
`555`	`555`	`if (digest != NULL)`
`@@ -877,7 +877,7 @@ SHA512_Last(SHA512_CTX *context)`
`877`	`877`	`}`
`878`	`878`
`879`	`879`	`void`
`880`		`-SHA512_Final(uint8 digest[], SHA512_CTX *context)`
	`880`	`+SHA512_Final(uint8 digest[SHA512_DIGEST_LENGTH], SHA512_CTX *context)`
`881`	`881`	`{`
`882`	`882`	`/* If no digest buffer is passed, we don't bother doing this: */`
`883`	`883`	`if (digest != NULL)`
`@@ -922,7 +922,7 @@ SHA384_Update(SHA384_CTX context, const uint8 data, size_t len)`
`922`	`922`	`}`
`923`	`923`
`924`	`924`	`void`
`925`		`-SHA384_Final(uint8 digest[], SHA384_CTX *context)`
	`925`	`+SHA384_Final(uint8 digest[SHA384_DIGEST_LENGTH], SHA384_CTX *context)`
`926`	`926`	`{`
`927`	`927`	`/* If no digest buffer is passed, we don't bother doing this: */`
`928`	`928`	`if (digest != NULL)`
`@@ -966,7 +966,7 @@ SHA224_Update(SHA224_CTX context, const uint8 data, size_t len)`
`966`	`966`	`}`
`967`	`967`
`968`	`968`	`void`
`969`		`-SHA224_Final(uint8 digest[], SHA224_CTX *context)`
	`969`	`+SHA224_Final(uint8 digest[SHA224_DIGEST_LENGTH], SHA224_CTX *context)`
`970`	`970`	`{`
`971`	`971`	`/* If no digest buffer is passed, we don't bother doing this: */`
`972`	`972`	`if (digest != NULL)`