🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@SilasMarvin
Copy link
Contributor

No description provided.

@SilasMarvin SilasMarvin requested a review from levkk November 29, 2023 23:16
@levkk
Copy link
Contributor

levkk commented Nov 29, 2023

🚀 🌔 🏆

Quick question re: API change from String to JsonB for the transform_stream, is that backwards compatible? I don't suppose we have a lot of adoption of those new methods yet since we haven't actually released 2.8.0 yet "officially", but still would be nice to keep those working if we can.

@SilasMarvin
Copy link
Contributor Author

🚀 🌔 🏆

Quick question re: API change from String to JsonB for the transform_stream, is that backwards compatible? I don't suppose we have a lot of adoption of those new methods yet since we haven't actually released 2.8.0 yet "officially", but still would be nice to keep those working if we can.

It is a breaking change unfortunately. It was a bad choice on my side to make it a string. I spoke with Montana about it, and it hasn't been released and I'm the only one using it so not too worried. Before we ship and merge this I need to make adjustments to our frontend or it will break something though

@levkk
Copy link
Contributor

levkk commented Nov 30, 2023

Sounds good!

@SilasMarvin SilasMarvin merged commit 0be25d0 into master Dec 1, 2023
@SilasMarvin SilasMarvin deleted the silas-open-source-ai-better-rebase branch December 1, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants