Dan product notifications #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Jun 14, 2024
| pub fn update_viewed(new: &Vec<String>, cookies: &CookieJar<'_>) { | ||
| let mut cookie = Cookie::new("session", format!(r#"{{"notifications": {:?}}}"#, new)); | ||
| pub fn update_viewed(new: &Vec<NotificationCookie>, cookies: &CookieJar<'_>) { | ||
| let serialized = new.iter().map(|x| x.to_string()).collect::<Vec<String>>(); |
Contributor
There was a problem hiding this comment.
You want to use serde_json::to_string
levkk
reviewed
Jun 14, 2024
|
|
||
| impl std::fmt::Display for NotificationCookie { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let mut rsp = format!(r#"{{"id": "{}""#, self.id.clone()); |
levkk
reviewed
Jun 14, 2024
| self | ||
| } | ||
|
|
||
| pub fn json(body: String) -> Response { |
Contributor
There was a problem hiding this comment.
We should move this to pgml_components crate.
levkk
reviewed
Jun 14, 2024
| .into_iter() | ||
| .map(|x| x.as_str().unwrap().to_string()) | ||
| .collect::<Vec<String>>(), | ||
| .map(|x| serde_json::from_str::<NotificationCookie>(&x.to_string()).unwrap()) |
Contributor
There was a problem hiding this comment.
This is not backwards compatible. You need to catch the deserialization error here and either bubble up the error, convert the old format to the new one, or return a default value.
chillenberger
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit d1c7351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.