🌐 AI搜索 & 代理 主页
Skip to content

Dan notifications backwards compatible #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chillenberger wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Dan notifications backwards compatible #1531

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4b3e74
make session backwards compatible
chillenberger Jun 14, 2024
e1f64d6
add tests
chillenberger Jun 16, 2024
61cb28c
clean
chillenberger Jun 16, 2024
3bfee36
Session cookie deserializaiton
levkk Jun 17, 2024
23fb688
safely unwrap context notification
chillenberger Jun 17, 2024
7bc6f65
Merge remote-tracking branch 'origin/levkk-cookie-test' into dan-noti…
chillenberger Jun 17, 2024
c641b70
clean up tests
chillenberger Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
safely unwrap context notification
  • Loading branch information
@chillenberger
chillenberger committed Jun 17, 2024
commit 23fb688e49ad8d2633c388e9b86dc85a4630b8d2
6 changes: 2 additions & 4 deletions pgml-dashboard/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,10 @@ pub fn replace_banner_product(

Notifications::update_viewed(&all_notification_cookies, cookies);

// Get the notification that triggered this call..
// unwrap notifications if fine since we should panic if this is missing.
let last_notification = context
let last_notification: Option<Notification> = context
.notifications
.as_ref()
.unwrap()
.unwrap_or(&vec![] as &Vec<Notification>)
.clone()
.into_iter()
.find(|n: &Notification| -> bool { n.id == id });
Expand Down