Add some return types #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfc81b2 to
62d8436
Compare
Member
|
LGTM |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 4, 2021
…r (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] fix parsing return types in DebugClassLoader | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In 5.3, we might want to make `SYMFONY_PATCH_TYPE_DECLARATIONS=deprecations=1` the default, so that ppl know when they're missing some return types when they inherit some classes from vendors. This would fix https://github.com/orgs/symfony/projects/1#card-30856423 On 4.4, we have to disable this mode of reporting until these PRs are merged: - twigphp/Twig#3481 - doctrine/collections#269 - predis/predis#678 Commits ------- 58e32b3 [ErrorHandler] fix parsing return types in DebugClassLoader
symfony-splitter
pushed a commit
to symfony/error-handler
that referenced
this pull request
Feb 4, 2021
…r (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] fix parsing return types in DebugClassLoader | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In 5.3, we might want to make `SYMFONY_PATCH_TYPE_DECLARATIONS=deprecations=1` the default, so that ppl know when they're missing some return types when they inherit some classes from vendors. This would fix https://github.com/orgs/symfony/projects/1#card-30856423 On 4.4, we have to disable this mode of reporting until these PRs are merged: - twigphp/Twig#3481 - doctrine/collections#269 - predis/predis#678 Commits ------- 58e32b3c2a [ErrorHandler] fix parsing return types in DebugClassLoader
62d8436 to
c551fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making these return types explicit in the annotation, we preemptively tell consumers that some next major of Predis or PHP 9 might add real return types here.
These annotations are leveraged by Symfony's
DebugClassLoaderto help one spot some missing return types in their app. That's how I spotted these. They relate only to PHP internal's base types / magic methods.