gh-118362: Skip tests when threading isn't available #118666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
!buildbot ios |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit ff5a757 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
colesbury
approved these changes
May 6, 2024
freakboy3742
approved these changes
May 6, 2024
Contributor
freakboy3742
left a comment
There was a problem hiding this comment.
The latest version with ThreadPoolExecutor and requires_working_threading looks good to me (for the iOS case, anyway).
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…8666) * Skip tests when threads aren't available * Use ThreadPoolExecutor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118454 introduced failures on iOS. Switches to a more general way of skipping tests when threading isn't available.