🌐 AI搜索 & 代理 主页
Skip to content

GH-134872: add ModuleNotFoundError suggestions #142512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
FFY00 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

GH-134872: add ModuleNotFoundError suggestions #142512

FFY00 wants to merge 2 commits into from

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Dec 10, 2025 •
edited by github-actions bot
Loading

@FFY00
pythongh-139899: Introduce MetaPathFinder.discover and PathEntryFinde…
8099249 
…r.discover

Signed-off-by: Filipe Laíns <lains@riseup.net>
@bedevere-app bedevere-app bot mentioned this pull request Dec 10, 2025
Open
@FFY00
Copy link
Member Author

FFY00 commented Dec 10, 2025

@Locked-chess-official, this draft PR includes the changes from GH-139900, introducing the .discover() method, and my initial proposed traceback implementation.

I think it should address the concerns you raised in GH-139899, could you give it a look?

@FFY00
Copy link
Member Author

FFY00 commented Dec 10, 2025

Right now it doesn't special-case relative imports, but the message is still helpful.

Python 3.15.0a2+ free-threading build (heads/gh-139899:6816705de0c, Dec 10 2025, 12:54:51) [GCC 15.2.1 20251112] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import aa
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    import aa
  File "/home/anubis/git/cpython/test-cases/aa/__init__.py", line 1, in <module>
    from .bb import *
ModuleNotFoundError: No module named 'aa.bb'. Did you mean: 'aa.bbb'?

I think it should be alright for an initial implementation, and then we can improve — just trying to make the scope smaller to hopefully guarantee this proposal doesn't lose momentum and ends up stalled.

@FFY00
pythongh-134872: Add traceback suggestions for ModuleNotFoundError
889c7ce 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 force-pushed the ModuleNotFoundError-suggestions branch from 3ef83d6 to 889c7ce Compare December 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon will be requested when the pull request is marked ready for review brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan will be requested when the pull request is marked ready for review ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw will be requested when the pull request is marked ready for review warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FFY00