🌐 AI搜索 & 代理 主页
Skip to content

gh-142489: Increase ssl_handshake_timeout in asyncio tests #142523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Dec 10, 2025
Merged

gh-142489: Increase ssl_handshake_timeout in asyncio tests #142523

vstinner merged 3 commits into from
Dec 10, 2025
+17 −23

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 10, 2025 •
edited by bedevere-app bot
Loading

Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.

@vstinner
pythongh-142489: Increase ssl_handshake_timeout in asyncio tests
916f011 
Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
@vstinner vstinner requested a review from gpshead as a code owner December 10, 2025 15:35
@vstinner vstinner requested a review from picnixz as a code owner December 10, 2025 15:35
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Dec 10, 2025
@bedevere-app bedevere-app bot mentioned this pull request Dec 10, 2025
Closed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Dec 10, 2025
@hroncok
Copy link
Contributor

hroncok commented Dec 10, 2025

Thanks. I'll check if this makes a difference in ELN/EPEL builds.

@hroncok
Copy link
Contributor

hroncok commented Dec 10, 2025

I submitted 5 builds each for Python 3.15.0a2 (on ELN), 3.14.2 (on ELN), and 3.13.11 (on EPEL 10.1), with this PR backported as well as 5 builds each without it.

Statistically, this improves things.

Without this patch, 7 out of the total 15 builds failed with ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection or ConnectionAbortedError: SSL handshake is taking longer than 67.5 seconds: aborting the connection.

With this patch applied, only one failed with ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection. It was a Python 3.13.11 build on EPEL 10.1 https://koji.fedoraproject.org/koji/taskinfo?taskID=139890933

What worries me a bit is that the exception still mentions 67.5 or 60.0 seconds. As if the SSL handshake had its own timeout set?

@vstinner
Copy link
Member Author

vstinner commented Dec 10, 2025

With this patch applied, only one failed with ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection. It was a Python 3.13.11 build on EPEL 10.1 https://koji.fedoraproject.org/koji/taskinfo?taskID=139890933

Hum. There were remaining open_connection() calls with the default timeout of asyncio.constants.SSL_HANDSHAKE_TIMEOUT seconds (60 seconds). I updated the PR to set the timeout to LONG_TIMEOUT instead.

What worries me a bit is that the exception still mentions 67.5 or 60.0 seconds. As if the SSL handshake had its own timeout set?

Yes, it's asyncio.constants.SSL_HANDSHAKE_TIMEOUT default value of 60 seconds.

support.LONG_TIMEOUT is a least 5 minutes.

@hroncok
Copy link
Contributor

hroncok commented Dec 10, 2025

Trying again.

@vstinner vstinner enabled auto-merge (squash) December 10, 2025 22:01
@vstinner vstinner merged commit dc3ece2 into python:main Dec 10, 2025
44 checks passed
@vstinner vstinner deleted the test_asyncio branch December 10, 2025 22:21
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 10, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2025
@vstinner @miss-islington
pythongh-142489: Increase ssl_handshake_timeout in asyncio tests (pyt…
3ae2376 
…honGH-142523)

Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
And add the HANDSHAKE_TIMEOUT constant.
(cherry picked from commit dc3ece2)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2025
@vstinner @miss-islington
pythongh-142489: Increase ssl_handshake_timeout in asyncio tests (pyt…
8aac6b3 
…honGH-142523)

Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
And add the HANDSHAKE_TIMEOUT constant.
(cherry picked from commit dc3ece2bc06d56c21ef81f86424b4598880ba1c8)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

GH-142545 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

GH-142546 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 10, 2025
@vstinner
Copy link
Member Author

vstinner commented Dec 10, 2025

Merged, thanks for testing @hroncok. I hope that this change will make timeout errors less likely on very slow CIs.

vstinner added a commit that referenced this pull request Dec 10, 2025
@miss-islington @vstinner
[3.13] gh-142489: Increase ssl_handshake_timeout in asyncio tests (GH…
746f8ed 
…-142523) (#142546)

gh-142489: Increase ssl_handshake_timeout in asyncio tests (GH-142523)

Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
And add the HANDSHAKE_TIMEOUT constant.
(cherry picked from commit dc3ece2)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Dec 10, 2025
@miss-islington @vstinner
[3.14] gh-142489: Increase ssl_handshake_timeout in asyncio tests (GH…
cbec73c 
…-142523) (#142545)

gh-142489: Increase ssl_handshake_timeout in asyncio tests (GH-142523)

Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
And add the HANDSHAKE_TIMEOUT constant.
(cherry picked from commit dc3ece2)

Co-authored-by: Victor Stinner <vstinner@python.org>
@hroncok
Copy link
Contributor

hroncok commented Dec 10, 2025

Trying again.

30 builds (10 for each Python version) and no timeout. Seems to work properly now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @hroncok @kumaraditya303