Remove python2 cta #1219
Merged
Remove python2 cta #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the 'which version' text from the download-banner box fixture and replaces it with a 'Looking for 2.7? See below' message to direct visitors to the release list on the downloads page. This change may have to be manually effected in the CMS in production.
Removes the 'which version' text from the homepage downloads box as well as the link for the latest Python 2 version.
Removes the 'which version' text from the homepage-downloads box fixture as well as the link to the latest Python 2 version. This change may have to be manually effected in the CMS in production.
Member
|
By the decree of @gvanrossum I hereby merge this. I'll update the CMS content after deploy @mpirnat. |
ewdurbin
pushed a commit
that referenced
this pull request
May 4, 2018
* Remove the Python 2 CTA buttons from the downloads page * Remove 'which version' text from download-banner box fixture Removes the 'which version' text from the download-banner box fixture and replaces it with a 'Looking for 2.7? See below' message to direct visitors to the release list on the downloads page. This change may have to be manually effected in the CMS in production. * Remove the Python 2 CTA buttons from the downloads supernav * Remove Python 2 from homepage downloads box Removes the 'which version' text from the homepage downloads box as well as the link for the latest Python 2 version. * Remove Python 2 from homepage-downloads box fixture Removes the 'which version' text from the homepage-downloads box fixture as well as the link to the latest Python 2 version. This change may have to be manually effected in the CMS in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218...
Remove the Python 2 CTA buttons from the downloads page
As described in the original issue.
Remove 'which version' text from download-banner box fixture
As described in the original issue, this may have to be manually effected in production since it's in the "box" stuff that appears to be managed in the CMS (and was how I had to do it locally for the change to take effect). It seemed reasonable to refresh the fixture though.
With these changes, it the banner area on the downloads page looks like this:
Remove the Python 2 CTA buttons from the downloads supernav
Not described in the original issue but seemed like a good idea for consistency.
With this change, the downloads supernav looks like this:
Remove Python 2 from homepage downloads box
Not described in the original issue, this also seemed like a good idea for consistency since the "wondering which version" text that the original issue is asking to remove also currently appears in the downloads box on the homepage. Again, I had to update the box in the CMS for the change to take effect, but the fixture has been updated to remove both the "which version" text as well as the link to the latest Python 2 version--this last seemed in the spirit of the CTA button removal.
With this change, the downloads box on the homepage looks like this:
Not Undertaken
There may be some opportunities to clean up the downloads view code to remove queries to get the latest Python 2 versions, which would trim a few ms, but I didn't feel comfortable ripping those out yet in case something else needed them or if the resulting change would be more extensive than desired. This can certainly be explored though.