🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@berinhard
Copy link
Contributor

This PR introduces updates to the benefits form from the sponsorship application process. The changes are on the package buttons and on benefits sections as well.

The buttons were updated to look more like as clickable and also the radio input is hidden. Here's how they are looking:

No selection
Screenshot from 2022-01-05 15-09-34

Selected
Screenshot from 2022-01-05 15-09-47

On mobile
Screenshot from 2022-01-05 15-16-39

The other change is a new behavior in the form. Since it is a big form, this PR now introduces the option to collapse/expand sections. Here's how they're looking like now:

Screenshot from 2022-01-05 16-12-31

@berinhard berinhard requested a review from ewdurbin January 5, 2022 19:28
@ewdurbin
Copy link
Member

ewdurbin commented Jan 7, 2022

Screen Shot 2022-01-07 at 1 55 51 PM

Looks like there are some minor overflows on some sizing.

Also I noted that when selecting a new package, it auto expands all sections that were previously collapsed. If there were some way to keep expand/collapse state when switching packages that might be less jarring for users.

@ewdurbin
Copy link
Member

@berinhard I pushed a commit to revert the transition point back to 1200px, please take a look. it slightly decreases the font size of the package name as it approaches the breakpoint in order to retain the rather reasonable 1200px width. I fear 1500px might be a little wide.

My sass-compiler was spitting out a huge swath of changes, so I have not included compiled css with the push.

If you're OK with the proposed changes, I think we're all set here!

@berinhard
Copy link
Contributor Author

@ewdurbin yep, the font-size you propose works smoothly. I added 2 new commits, one for a missing line on CSS and the other to roll back to 1200px on the final CSS media queries.

@ewdurbin
Copy link
Member

Thanks @berinhard!

@ewdurbin ewdurbin merged commit 751ed17 into main Jan 12, 2022
@ewdurbin ewdurbin deleted the topic/sponsorship-application-styles branch January 12, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants