Add filters to logo placement API #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is also present at #1981, but since pypi integration also needs it, I decided to duplicate it to not have the integration between services pending on an open PR.
ewdurbin
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filter options to
/api/v2/sponsors/logo-placement/. Now clients can filter bypublisherandlogo_placevia querystring. Both filters are optional, but if they are being used in a request with invalid values the request will be treated as a bad request.The filters will be handful for pypi to filter by their logos and use the API data to place sponsors logo. The following request's, for example, will return only the sponsors which should be displayed at Pypi's sponsors page:
localhost:8000/api/v2/sponsors/logo-placement/?publisher=pypi&logo_place=sponsors