🌐 AI搜索 & 代理 主页
Skip to content

API endpoint to filter assets by internal name #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewdurbin merged 9 commits into from
Feb 25, 2022
Merged

API endpoint to filter assets by internal name #1998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
43f70ea
Move serializers to proper file in sponsors app
berinhard Feb 25, 2022
265413a
Minimal config to have the endpoint set up
berinhard Feb 25, 2022
ec3e275
Introduce custom query set on generic assets to list all specific imp…
berinhard Feb 25, 2022
376a39f
Refactor to rely on DRF default behavior to serialize bad requests
berinhard Feb 25, 2022
520af9b
Serialize text assets
berinhard Feb 25, 2022
264e8ba
Serialize image value as URL
berinhard Feb 25, 2022
2bdd1d6
Serialize sponsor name within asset information
berinhard Feb 25, 2022
ab7da79
Limit reportlab version to one that satisfies dependency but doesn't …
berinhard Feb 25, 2022
ebc2227
Also serializes sponsor slug
berinhard Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Introduce custom query set on generic assets to list all specific imp… 
…lementations
  • Loading branch information
@berinhard
berinhard committed Feb 25, 2022
commit ec3e27536b3fd344db27f08e53650d3d5206d188
3 changes: 1 addition & 2 deletions sponsors/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,7 @@ def get_child_models(self, *args, **kwargs):
return GenericAsset.all_asset_types()

def get_queryset(self, *args, **kwargs):
classes = self.get_child_models(*args, **kwargs)
return self.model.objects.select_related("content_type").instance_of(*classes)
return GenericAsset.objects.all_assets()

def get_actions(self, request):
actions = super().get_actions(request)
Expand Down
4 changes: 3 additions & 1 deletion sponsors/models/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
from polymorphic.managers import PolymorphicManager
from polymorphic.models import PolymorphicModel

from sponsors.models.managers import GenericAssetQuerySet


def generic_asset_path(instance, filename):
"""
Expand All @@ -28,7 +30,7 @@ class GenericAsset(PolymorphicModel):
"""
Base class used to add required assets to Sponsor or Sponsorship objects
"""
objects = PolymorphicManager()
objects = GenericAssetQuerySet.as_manager()
non_polymorphic = models.Manager()

# UUID can't be the object ID because Polymorphic expects default django integer ID
Expand Down
8 changes: 8 additions & 0 deletions sponsors/models/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,11 @@ def provided_assets(self):
from sponsors.models.benefits import ProvidedAssetMixin
provided_assets_classes = ProvidedAssetMixin.__subclasses__()
return self.instance_of(*provided_assets_classes).select_related("sponsor_benefit__sponsorship")


class GenericAssetQuerySet(PolymorphicQuerySet):

def all_assets(self):
from sponsors.models import GenericAsset
classes = GenericAsset.all_asset_types()
return self.select_related("content_type").instance_of(*classes)