This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Add new acl system #254
Open
Add new acl system #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95b6bd0 to
c67c39e
Compare
nzlosh
added a commit
to nzlosh/python-consul
that referenced
this pull request
May 24, 2019
abarbare
reviewed
Dec 23, 2019
Author
|
@abarbare do you have some other request changes / reviews ? |
|
@Dudesons Actually yes, the I did a patch on my fork but I'm not 100% satisfied at this time of this solution as it mixes query string and body parameters but it works https://github.com/abarbare/python-consul/pull/1/files |
636f367 to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cablehead,
It concerns new acl system for consul 1.4 and 1.5
In this pr I had the possibility to manage the following parts of the ACL api: