Move ctrlplot code prior to upcoming PR #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slivingston
approved these changes
Jul 21, 2024
slivingston
reviewed
Jul 21, 2024
control/ctrlplot.py
Outdated
| # Utility functions | ||
| # | ||
| # These functions are used by plotting routines to provide a consistent way | ||
| # of processing and displaing information. |
Member
There was a problem hiding this comment.
Suggested change
| # of processing and displaing information. | |
| # of processing and displaying information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves around some functions from
freqplot.pyandtimeplot.pytoctrlplot.pyin preparation for an upcoming PR that is going to modify those functions. There is no change in functionality, but I want people to be able to see the changes I am making to functions inctrlplot.pyin the upcoming PR => need to move things around first so thatgit diffcan highlight the changes.Summary of changes:
rcParamsdict used to customize plotting functions is now inctrlplot.py(instead of having two separate but identicalrcParamsinfreqplot.pyandtimpelot.py)._process_ax_keywordutility function is now inctrlplot.py(instead offreqplot.py)._process_line_labelsutility function is now inctrlplot.py(instead offreqplot.py)._get_line_labelsutility function is now inctrlplot.py(instead offreqplot.py)._add_arrows_to_line2Dutility function is now inctrlplot.py(instead offreqplot.py).grid.py.