BugFix: `place_acker` output should be 2D array #1181

guptavaibhav0 · 2025-09-09T09:33:00Z

place_acker function's output is a 1D array, while it should be a 2D array as described in its doc string.

coveralls · 2025-09-09T09:49:40Z

coverage: 94.734%. remained the same
when pulling 37ccb27 on guptavaibhav0:main
into abeb0e4 on python-control:main.

murrayrm · 2025-11-09T02:12:40Z

Good fix, @guptavaibhav0! Can you also update the unit test in statefbk_test.py so that it exhibits the error. On line 273, if you change

ss(sys.A - sys.B * K, sys.B, sys.C, sys.D)

to read

ss(sys.A - sys.B @ K, sys.B, sys.C, sys.D)

then the previous code will generate an error.

BugFix: place_acker output should be 2D matrix

37ccb27

Provide feedback