fix compiler warning #1226
Merged
fix compiler warning #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 1 1
Lines 291 291
=======================================
Hits 251 251
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
Author
|
@lostmsu please review |
filmor
approved these changes
Sep 17, 2020
Member
filmor
left a comment
There was a problem hiding this comment.
Looks good to me, can we make PyObject.obj readonly now?
lostmsu
requested changes
Sep 17, 2020
Member
|
@koubaa sorry, reviewed, but forgot to submit :-) |
07c2bfd to
945db38
Compare
Contributor
Author
It's a good thought! I tried it, but PyObject.Dispose sets it to IntPtr.Zero and that is a compiler error. |
lostmsu
requested changes
Sep 18, 2020
f2ddb69 to
8d74e1c
Compare
lostmsu
requested changes
Sep 20, 2020
lostmsu
requested changes
Sep 20, 2020
lostmsu
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.