Reworked the way .NET objects are constructed from Python #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d8c1f4 to
25a94e4
Compare
was: tp_new implementation would call .NET constructor and return a fully constructed object now: Except for some special .NET types tp_new creates uninitialized .NET object, which is later initialized by calling __init__. __init__ is set using type dictionary to a MethodObject, that contains ConstructorInfo[] instead of MethodInfo[] This allows Python to: 1) freely override __init__ 2) when deriving from .NET types call base __init__ (e.g. .NET constructor), and choose the overload as needed fixes pythonnet#238
25a94e4 to
c091caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Was:
tp_newimplementation would call .NET constructor and return a fully constructed objectNow:
Except for some special .NET types
tp_newcreates uninitialized .NET object, which is later initialized by callinguninitialized_inst.__init__(...).__init__is set in type dictionary to aMethodObject, that containsConstructorInfo[]instead ofMethodInfo[]This allows Python to:
__init__when deriving from .NET types__init__(e.g. .NET constructor), and choose the overload as neededFailing to call base
__init__in this scenario will lead to an undefined behavior.Does this close any currently open issues?
fixes #238
Checklist
Check all those that are applicable and complete.
CHANGELOG