🌐 AI搜索 & 代理 主页
Skip to content

1990 py int to string fix #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmadsen-ks wants to merge 3 commits into from
Closed

1990 py int to string fix #1991

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
486a4b2
1990 PyInt To String Bug: unit test
rmadsen-ks Oct 28, 2022
21e2f88
1990 Fixed bug related to converting number to a string
rmadsen-ks Oct 28, 2022
c12032f
Moved test_object_string_format to a more fitting location.
rmadsen-ks Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1990 Fixed bug related to converting number to a string 
There was an issue with values between 128 and 256, possibly because of some bug inside BigInteger, which I did not fully understand.

Anyway, it seems that a simpler solution is to just use LongInteger when possible.
  • Loading branch information
@rmadsen-ks
rmadsen-ks committed Oct 28, 2022
commit 21e2f88f58663f0348d9c6ce2d1d629a4ac787a4
1 change: 1 addition & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,4 @@
- ([@alxnull](https://github.com/alxnull))
- ([@gpetrou](https://github.com/gpetrou))
- Ehsan Iran-Nejad ([@eirannejad](https://github.com/eirannejad))
- Rolf Madsen ([@rmadsen-ks](https://github.com/rmadsen-ks))
3 changes: 2 additions & 1 deletion src/runtime/PythonTypes/PyInt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ public BigInteger ToBigInteger()
public string ToString(string format, IFormatProvider formatProvider)
{
using var _ = Py.GIL();
return ToBigInteger().ToString(format, formatProvider);
object val = Runtime.PyLong_AsLongLong(obj);
return val?.ToString() ?? ToBigInteger().ToString(format, formatProvider);
}

public override TypeCode GetTypeCode() => TypeCode.Int64;
Expand Down