Fix the issue of sys.argv being cleared on import clr. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@filmor just fixed the test for this on test against v2.2.2 - https://travis-ci.org/vmuriart/pythonnet/jobs/204904097 |
bac3ab3 to
9e1a0e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 63.49% 63.51% +0.02%
==========================================
Files 60 60
Lines 5219 5222 +3
Branches 857 858 +1
==========================================
+ Hits 3314 3317 +3
Misses 1685 1685
Partials 220 220
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404.
What does this implement/fix? Explain your changes.
Introduces a
setSysArgvflag to allInitializefunctions inPythonEngine, defaulting totrueand set tofalseforInitExtsuch thatimport clrdoesn't callPySys_SetArgvEx.Does this close any currently open issues?
#404.
Any other comments?
The test should already be in from another PR, from what I understood and since the change introducing this issue has not been released, yet, I don't think it need to go into the changelog.