Revert change to use Assembly.Load(Byte[]) #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b65fa30.
…rom a file. This fixes problems when trying to import pre-loaded assemblies that are embedded as resources.
…rary dirs for python built with --enable-shared.
Contributor
Author
|
@adamklein, would you mind checking this actually fixes your original problem please? :) |
|
Yes, sorry for the delay - will check today! |
|
Confirmed this works! |
Contributor
Author
|
Excellent! :) I'll go ahead and merge this then. |
twastvedt
added a commit
to autodesk-forks/pythonnet
that referenced
this pull request
Mar 17, 2025
* add cache for extensions * Use out --------- Co-authored-by: Trygve Wastvedt <trygve.wastvedt@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Assembly.Load(Byte[]) created problems loading assemblies containing unmanaged code.
http://stackoverflow.com/questions/2945080/how-do-i-dynamically-load-raw-assemblies-that-contains-unmanaged-codebypassing
The change to use Assemble.Load(Byte[]) was originally made as a workaround to fix a problem where the Python.Runtime would get loaded multiple times when using nPython (once from the resource, and then later from the file on disk). The change forced it to go through the resolve mechanism, which found the embedded resource.
This change fixes the same problem much more simply, while using the normal Assembly.LoadFrom(path) method. Before attempting to load an assembly from disk it checks to see if an assembly with the same name is already loaded.