🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@ortex
Copy link
Member

@ortex ortex commented May 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #117 (3f9b487) into main (1685cdc) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
- Coverage     76.51%   76.45%   -0.06%     
+ Complexity       81       80       -1     
============================================
  Files            24       24              
  Lines           413      412       -1     
  Branches          2        2              
============================================
- Hits            316      315       -1     
  Misses           93       93              
  Partials          4        4              
Impacted Files Coverage Δ
...in/java/org/rocstreaming/roctoolkit/Interface.java 100.00% <ø> (ø)
...in/java/org/rocstreaming/roctoolkit/RocSender.java 84.21% <50.00%> (ø)
.../java/org/rocstreaming/roctoolkit/RocReceiver.java 94.73% <100.00%> (ø)

@gavv
Copy link
Member

gavv commented May 29, 2023

LGTM. @ortex not merging because coverage failed, if that's OK (I guess), feel free to merge.

@ortex ortex merged commit 3acddfd into main May 30, 2023
@ortex ortex deleted the remove_getter_from_interface branch May 30, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants