Feature/finalizers #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make AutoCloseThread daemon; use blocking api to remove object from referenceQueue
Closed
cbe53da to
4284066
Compare
b6cacb0 to
43a3f34
Compare
gavv
reviewed
Dec 3, 2022
Comment on lines
+35
to
+38
| private static long tryOpen(ContextConfig config) throws IllegalArgumentException, Exception { | ||
| if (config == null) throw new IllegalArgumentException(); | ||
| return open(config); | ||
| } |
Member
There was a problem hiding this comment.
Nitpick: since we anyway have validation in native open(), then we can move this check there and get rid of tryOpen at all, to keep all validation in one place.
Member
Author
There was a problem hiding this comment.
let's fix it in #4, I'll update issue after merge
This comment was marked as resolved.
This comment was marked as resolved.
bd4dbf0 to
cd818a0
Compare
gavv
approved these changes
Dec 5, 2022
Member
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #32 . Fixed #5