ZJIT: Add dump to file for --zjit-stats #15414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cda5eb to
a9c26fa
Compare
Member
We probably don't need to support saving stats as WDYT about renaming |
Contributor
Author
Sure, I'd do that. |
This comment has been minimized.
This comment has been minimized.
k0kubun
approved these changes
Dec 4, 2025
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Dec 10, 2025
The `--zjit-stats-quiet` and `--zjit-stats=quiet` options differ. The latter option, `=quiet`, does print stats to the file "quiet", but does not suppress output like yjit option `--yjit-stats=quiet`. Fix up ruby#15414, 29c29c2
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Shopify#801
Adds functionality to provide a path to
--zjit-statsin order to write there.Note that doing so with multiple runs will truncate the old file.
Also,quietis used for separate functionality, so you cannot pass a file calledquietto write to.Also change
--zjit-stats=quietto--zjit-stats-quiet.